Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image releases with different Go version than binaries #251

Closed
jdolitsky opened this issue Mar 18, 2021 · 3 comments · Fixed by #384
Closed

Docker image releases with different Go version than binaries #251

jdolitsky opened this issue Mar 18, 2021 · 3 comments · Fixed by #384
Milestone

Comments

@jdolitsky
Copy link
Contributor

$ oras version
Version:        0.11.1
Go version:     go1.16.2
Git commit:     5bfe0ab04a0f6fcdc5de4294cc79fb5b2e23a9a5
Git tree state: clean
$ docker run -it --rm -v $(pwd):/workspace ghcr.io/deislabs/oras:v0.11.1 version
Version:        0.11.1
Go version:     go1.15.7
Git commit:     5bfe0ab04a0f6fcdc5de4294cc79fb5b2e23a9a5
Git tree state: clean

How should we keep these best in sync other than using latest tag? Should we have a GO_VERSION file that is used both for CI and Dockerfile?

@deitch
Copy link
Contributor

deitch commented Mar 18, 2021

A few possibilities:

  • set the go version in the Makefile and pass it via a --build-arg when building in Docker, via ARG in the Dockerfile
  • build the distributed artifact using the Dockerfile
  • do it manually 😄

@sajayantony
Copy link
Contributor

Glad we don't have a latest. This makes pre-release pipelines easier since the tag would be the full version. For e.g. v0.2.0-alpha.1

@shizhMSFT shizhMSFT added this to the v0.13.0 milestone May 7, 2022
@shizhMSFT
Copy link
Contributor

Once we resolves #377, we will have the same go version for the same oras version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants