Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky console test #1543

Closed
1 task done
qweeah opened this issue Nov 25, 2024 · 0 comments · Fixed by #1544
Closed
1 task done

flaky console test #1543

qweeah opened this issue Nov 25, 2024 · 0 comments · Fixed by #1544
Labels
bug Something isn't working triage New issues or PRs to be acknowledged by maintainers

Comments

@qweeah
Copy link
Contributor

qweeah commented Nov 25, 2024

What happened in your environment?

Sometimes when running the unit test, the console test might fail unexpectedly with error

> go test -count=20 ./...                                           
...
ok      oras.land/oras/cmd/oras/internal/display/status 0.080s
--- FAIL: TestConsole_OutputTo (0.00s)
    console_test.go:112: OutputTo output error: failed to find "^[8^[[1Ftest string^[[0m\r\n^[[0K" in ""
FAIL
FAIL    oras.land/oras/cmd/oras/internal/display/status/console 0.073s
ok  

What did you expect to happen?

The test should pass

How can we reproduce it?

Run all unit tests with high repetition count, e.g. 20, and it's likely to happen

go test -count=20 ./...            

What is the version of your ORAS CLI?

Main branch build in 5280c67

What is your OS environment?

Ubuntu 24.04

Are you willing to submit PRs to fix it?

  • Yes, I am willing to fix it.
@qweeah qweeah added bug Something isn't working triage New issues or PRs to be acknowledged by maintainers labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage New issues or PRs to be acknowledged by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant