Replies: 5 comments 8 replies
-
If we had to choose one, I think I'd slightly prefer spinner |
Beta Was this translation helpful? Give feedback.
-
Added a new implementation which separated the output of progress bar into a newline @sajayantony @TerryHowe any feedback? |
Beta Was this translation helpful? Give feedback.
-
Even though it uses more vertical space, I like that implementation better than the tighter one. I like the npm style one less, but I just haven't done a lot of javascripting! |
Beta Was this translation helpful? Give feedback.
-
It might be helpful to display the time usage for uploading/downloading each blob in the progress bar. |
Beta Was this translation helpful? Give feedback.
-
The two-line one LGTM. It would be better if the cells for progress in size, %, and time are aligned. |
Beta Was this translation helpful? Give feedback.
-
Problem
As is pointed out in #940 and #893, oras commands might halt when processing data transfer tasks without any user feedback.
Solution
If ORAS user is using a terminal to run the command, we can compose an UI in the terminal and display progress status of the execution.
Goals
oras manifest fetchNon-goals
PoC
I had an implementation in my own fork based on below MVC design:
I cut three releases with different UI:
spinner: https://github.com/qweeah/oras/releases/tag/v1.2.0-spinner
![asciicast](https://camo.githubusercontent.com/3675bd4eaa19d964fbd066e8930550b76e53a89bfa6fddf28896efa2329df74e/68747470733a2f2f61736369696e656d612e6f72672f612f3630323639382e737667)
progress bar: https://github.com/qweeah/oras/releases/tag/v1.2.0-bar
![asciicast](https://camo.githubusercontent.com/528351cc501ca6f1fdf1bfd7543a5af5f2420aa31daed442527d7306604286b5/68747470733a2f2f61736369696e656d612e6f72672f612f6341395079417a4266387a51656f445461436e6147314153662e737667)
two-line output with progress bar: https://github.com/qweeah/oras/releases/tag/v1.2.0-2line-bar
![asciicast](https://camo.githubusercontent.com/bea65deb520bae6a8a5bf992071c6037c21b1aa4a0fde95f240271018085d4c5/68747470733a2f2f61736369696e656d612e6f72672f612f3630333331382e737667)
(This implementation breaks current output style and split output of one blob into 2 lines)
To try out more commands, you may installed via below command
Beta Was this translation helpful? Give feedback.
All reactions