doc: align dev checklist to applied practices in ORAS 1.1.0-rc.1 release #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <[email protected]>
qweeah
requested review from
asmitbm,
FeynmanZhou,
sajayantony,
shizhMSFT,
SteveLasker and
vsoch
as code owners
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
qweeah
changed the title
shizhMSFT
reviewed
Jul 13, 2023
Signed-off-by: Billy Zha <[email protected]>
FeynmanZhou
reviewed
Jul 13, 2023
Signed-off-by: Billy Zha <[email protected]>
shizhMSFT
reviewed
Jul 14, 2023
|
|
||
| ### Request to vote | ||
| 1. Open a release PR to update oras version: replace [current stable version](https://github.com/oras-project/oras/blob/main/internal/version/version.go#L20) with upcoming release version | ||
| - The target branch is `main` |
There was a problem hiding this comment.
If we want to release v1.1.0 or v1.1.0-rc.2, the target branch is release-1.1 as we already have a release branch.
docs/community/developer_guide.mdx
Outdated
Comment on lines
93
to
95
| - The target branch is `main` | ||
| - The title should be `bump: tag and release ORAS CLI v<major>.<minor>[-<pre-release>]` | ||
| - The description must reference the digest of version bump up commit for voting |
There was a problem hiding this comment.
nit: code style: consistency: 4 spaces for indentation
Signed-off-by: Billy Zha <[email protected]>
|
Conflicts and comments here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #213