Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cloudavenue_s3_bucket_cors_configuration resource/datasource #589

Conversation

azrod
Copy link
Member

@azrod azrod commented Oct 18, 2023

Description of your changes

Create new resource and datasource cloudavenue_s3_bucket_cors_configuration

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

@crown-app
Copy link

crown-app bot commented Oct 18, 2023

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@azrod azrod marked this pull request as ready for review October 18, 2023 11:54
@azrod azrod requested a review from a team as a code owner October 18, 2023 11:54
@azrod azrod self-assigned this Oct 18, 2023
@azrod azrod force-pushed the 578-new-resourcedatasource-add-feature-cloudavenue_s3_bucket_cors_configuration branch from 5175db9 to 601b610 Compare October 18, 2023 13:12
@azrod azrod force-pushed the 578-new-resourcedatasource-add-feature-cloudavenue_s3_bucket_cors_configuration branch from 601b610 to 5fdc3c6 Compare October 19, 2023 15:15
@azrod azrod force-pushed the 578-new-resourcedatasource-add-feature-cloudavenue_s3_bucket_cors_configuration branch from 5fdc3c6 to 0f57505 Compare October 19, 2023 15:16
@azrod azrod force-pushed the 578-new-resourcedatasource-add-feature-cloudavenue_s3_bucket_cors_configuration branch from 0f57505 to fc726b3 Compare October 19, 2023 15:17
@dmicheneau dmicheneau merged commit 33d30a3 into main Oct 19, 2023
4 checks passed
@dmicheneau dmicheneau deleted the 578-new-resourcedatasource-add-feature-cloudavenue_s3_bucket_cors_configuration branch October 19, 2023 15:19
azrod pushed a commit that referenced this pull request Oct 19, 2023
dmicheneau pushed a commit that referenced this pull request Oct 23, 2023
azrod pushed a commit that referenced this pull request Nov 8, 2023
azrod pushed a commit that referenced this pull request Nov 8, 2023
azrod pushed a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource/Datasource]: Add feature cloudavenue_s3_bucket_cors_configuration
2 participants