Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cloudavenue_s3_bucket resource/datasource #586

Merged
merged 1 commit into from
Oct 18, 2023
Merged

feat: add cloudavenue_s3_bucket resource/datasource #586

merged 1 commit into from
Oct 18, 2023

Conversation

azrod
Copy link
Member

@azrod azrod commented Oct 17, 2023

Description of your changes

Add new resource and datasource cloudavenue_s3_bucket

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

=== RUN   TestAccS3BucketResource
--- PASS: TestAccS3BucketResource (14.46s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  14.850s

@azrod azrod requested a review from a team as a code owner October 17, 2023 14:49
@azrod azrod linked an issue Oct 17, 2023 that may be closed by this pull request
[New Resource/Datasource]: Add feature cloudavenue_s3_bucket #576
Closed
@azrod azrod self-assigned this Oct 17, 2023
@azrod azrod force-pushed the 576-new-resourcedatasource-add-feature-cloudavenue_s3_bucket branch 2 times, most recently from dd42a57 to da7a4f4 Compare October 17, 2023 15:25
dmicheneau
dmicheneau requested changes Oct 17, 2023
View reviewed changes
internal/provider/s3/bucket_schema.go Outdated Show resolved Hide resolved
@azrod azrod force-pushed the 576-new-resourcedatasource-add-feature-cloudavenue_s3_bucket branch from da7a4f4 to f521f42 Compare October 18, 2023 06:08
@azrod azrod force-pushed the 576-new-resourcedatasource-add-feature-cloudavenue_s3_bucket branch from f521f42 to 9abd525 Compare October 18, 2023 06:10
@azrod azrod merged commit 1917c9b into main Oct 18, 2023
4 checks passed
@azrod azrod deleted the 576-new-resourcedatasource-add-feature-cloudavenue_s3_bucket branch October 18, 2023 06:29
azrod pushed a commit that referenced this pull request Oct 18, 2023
chore: update CHANGELOG.md for #586
c92f1c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmicheneau dmicheneau dmicheneau approved these changes

Assignees

@azrod azrod

Labels
Feature size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Resource/Datasource]: Add feature cloudavenue_s3_bucket
2 participants
@azrod @dmicheneau