Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ress/data cloudavenue_vdcg_network_isolated #885

Open
wants to merge 1 commit into
base: network-isolated
Choose a base branch
from
Open

feat: add ress/data cloudavenue_vdcg_network_isolated #885

wants to merge 1 commit into from

Conversation

azrod
Copy link
Member

@azrod azrod commented Dec 13, 2024 •
edited
Loading

Description of your changes

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

--- PASS: TestAccVDCGNetworkIsolatedDataSource (161.09s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  161.621s

--- PASS: TestAccVDCGNetworkIsolatedResource (540.02s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  540.955s

@azrod azrod linked an issue Dec 13, 2024 that may be closed by this pull request
[New Resource/Datasource]: cloudavenue_vdcg_network_isolated #878
Open
@cloudavenue-bot
Copy link

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@azrod azrod force-pushed the 878-new-resourcedatasource-cloudavenue_vdcg_network_isolated branch from ee81243 to 2b79dbb Compare December 13, 2024 10:07
@azrod azrod force-pushed the 878-new-resourcedatasource-cloudavenue_vdcg_network_isolated branch from 2b79dbb to f6a25e6 Compare December 13, 2024 10:14
@azrod azrod marked this pull request as ready for review December 13, 2024 10:15
@azrod azrod requested a review from a team as a code owner December 13, 2024 10:15
@azrod azrod changed the base branch from main to network-isolated December 13, 2024 10:19
@azrod
Copy link
Member Author

azrod commented Dec 13, 2024 

--- PASS: TestAccVDCGNetworkIsolatedResource (461.25s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  461.780s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmicheneau dmicheneau dmicheneau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Resource/Datasource]: cloudavenue_vdcg_network_isolated
2 participants
@azrod @dmicheneau