Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: schema medias catalog #384

Merged
merged 1 commit into from
Jul 19, 2023
Merged

refactor: schema medias catalog #384

merged 1 commit into from
Jul 19, 2023

Conversation

azrod
Copy link
Member

@azrod azrod commented Jul 13, 2023

Description of your changes

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

TF_ACC=1 go test -v -count=1 -timeout 600m github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/catalog/medias_datasource_test.go
=== RUN   TestAccCatalogMediasDatasource
--- PASS: TestAccCatalogMediasDatasource (19.26s)
PASS
ok      command-line-arguments  19.755s

@azrod azrod linked an issue Jul 13, 2023 that may be closed by this pull request
[Enhancement]: Add Superschema in catalog_medias_datasource #374
Closed
@azrod azrod requested a review from dmicheneau July 13, 2023 20:35
@azrod azrod force-pushed the 374-enhancement-add-superschema-in-catalog_medias_datasource branch from b8fdd4e to 74fa3c4 Compare July 13, 2023 20:38
@azrod azrod force-pushed the 374-enhancement-add-superschema-in-catalog_medias_datasource branch from 74fa3c4 to e1425e0 Compare July 13, 2023 20:41
@azrod azrod marked this pull request as ready for review July 13, 2023 20:41
@azrod azrod self-assigned this Jul 13, 2023
@dmicheneau dmicheneau merged commit 35ff8e9 into main Jul 19, 2023
@dmicheneau dmicheneau deleted the 374-enhancement-add-superschema-in-catalog_medias_datasource branch July 19, 2023 08:38
gaetanars pushed a commit that referenced this pull request Jul 19, 2023
chore: update CHANGELOG.md for #384
6e6c29b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmicheneau dmicheneau dmicheneau approved these changes

Assignees

@azrod azrod

Labels
category/catalog Refactor size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add Superschema in catalog_medias_datasource
2 participants
@azrod @dmicheneau