Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vapp): new cloudavenue_vapp_isolated_network_datasource #291

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

dmicheneau
Copy link
Member

@dmicheneau dmicheneau commented Apr 26, 2023

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

TF_ACC=1 go test -v ./internal/tests/vapp -run TestAccIsolatedNetworkDataSource
=== RUN   TestAccIsolatedNetworkDataSource
--- PASS: TestAccIsolatedNetworkDataSource (36.96s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/vapp        37.293s

@dmicheneau dmicheneau linked an issue Apr 26, 2023 that may be closed by this pull request
@dmicheneau dmicheneau force-pushed the 143-new-data-source-cloudavenue_vapp_isolated_network branch from d8d003d to 09481b0 Compare April 26, 2023 14:46
@crown-app crown-app bot added size/L and removed size/M labels Apr 26, 2023
@dmicheneau dmicheneau force-pushed the 143-new-data-source-cloudavenue_vapp_isolated_network branch 3 times, most recently from 12b9c51 to 2afbbc7 Compare April 26, 2023 15:08
internal/provider/common/network/schema.go Outdated Show resolved Hide resolved
internal/provider/common/vapp/vapp.go Outdated Show resolved Hide resolved
internal/provider/vapp/isolated_network_datasource.go Outdated Show resolved Hide resolved
internal/provider/vapp/isolated_network_datasource.go Outdated Show resolved Hide resolved
internal/provider/vapp/isolated_network_datasource.go Outdated Show resolved Hide resolved
@dmicheneau dmicheneau changed the title feat(vapp): Add 'cloudavenue_vapp_isolated_network_datasource' feat(vapp): new cloudavenue_vapp_isolated_network_datasource Apr 27, 2023
@dmicheneau dmicheneau force-pushed the 143-new-data-source-cloudavenue_vapp_isolated_network branch from 2afbbc7 to 39bdaa2 Compare April 28, 2023 07:41
@dmicheneau dmicheneau requested a review from azrod April 28, 2023 09:03
@dmicheneau dmicheneau force-pushed the 143-new-data-source-cloudavenue_vapp_isolated_network branch 2 times, most recently from 4bc12c2 to b227b4c Compare April 28, 2023 09:22
@dmicheneau dmicheneau force-pushed the 143-new-data-source-cloudavenue_vapp_isolated_network branch from ea11355 to bb6f780 Compare May 22, 2023 08:10
…urce'

Update internal/provider/vapp/isolated_network_datasource.go

Co-authored-by: Mickael Stanislas <[email protected]>
@dmicheneau dmicheneau force-pushed the 143-new-data-source-cloudavenue_vapp_isolated_network branch from bb6f780 to e0cb80b Compare May 22, 2023 08:21
@azrod azrod merged commit f7cb944 into main Jun 8, 2023
@azrod azrod deleted the 143-new-data-source-cloudavenue_vapp_isolated_network branch June 8, 2023 17:31
gaetanars pushed a commit that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: cloudavenue_vapp_isolated_network
2 participants