Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(network): Add data source cloudavenue_network_isolated #248

Merged
merged 3 commits into from
Apr 4, 2023
Merged

chore(network): Add data source cloudavenue_network_isolated #248

merged 3 commits into from
Apr 4, 2023

Conversation

dmicheneau
Copy link
Member

Add new data source cloudavenue_network_isolated
Use SuperShema

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

=== RUN   TestAccNetworkIsolatedDataSource
--- PASS: TestAccNetworkIsolatedDataSource (5.58s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/network     5.609s

@dmicheneau dmicheneau linked an issue Mar 31, 2023 that may be closed by this pull request
[New Data Source]: cloudavenue_network_isolated_v2 #176
Closed
@dmicheneau dmicheneau force-pushed the 176-new-data-source-cloudavenue_network_isolated_v2 branch from 44475bd to 96f7bc6 Compare March 31, 2023 11:46
@dmicheneau dmicheneau force-pushed the 176-new-data-source-cloudavenue_network_isolated_v2 branch from 96f7bc6 to c630bfc Compare April 3, 2023 07:30
@dmicheneau dmicheneau force-pushed the 176-new-data-source-cloudavenue_network_isolated_v2 branch from c630bfc to 3bbf555 Compare April 3, 2023 15:02
azrod
azrod approved these changes Apr 3, 2023
View reviewed changes
internal/provider/network/isolated_datasource.go Outdated Show resolved Hide resolved
@dmicheneau dmicheneau merged commit 72f4dcc into main Apr 4, 2023
@dmicheneau dmicheneau deleted the 176-new-data-source-cloudavenue_network_isolated_v2 branch April 4, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azrod azrod azrod approved these changes

Assignees
No one assigned
Labels
category/network Chore Feature Refactor size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Data Source]: cloudavenue_network_isolated_v2
3 participants
@dmicheneau @azrod @gaetanars