Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add cloudavenue_alb_pool #246

Merged
merged 8 commits into from
Apr 4, 2023
Merged

feat: Add cloudavenue_alb_pool #246

merged 8 commits into from
Apr 4, 2023

Conversation

gaetanars
Copy link
Contributor

@gaetanars gaetanars commented Mar 30, 2023 •
edited
Loading

Description of your changes

Add cloudavenue_alb_pool resource and datasource

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

❯ TF_ACC=1 go test -v -count=1 ./internal/tests/alb
=== RUN   TestAccAlbPoolDataSource
--- PASS: TestAccAlbPoolDataSource (6.39s)
=== RUN   TestAccAlbPoolResource
--- PASS: TestAccAlbPoolResource (18.08s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/alb 24.478s

@gaetanars gaetanars linked an issue Mar 30, 2023 that may be closed by this pull request
[New Resource]: cloudavenue_alb_pool #220
Closed
@crown-app
Copy link

crown-app bot commented Mar 30, 2023

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@gaetanars gaetanars requested review from azrod and dmicheneau March 30, 2023 14:13
@azrod azrod changed the title feat: Add cloudavenue_alb_pool feat: Add cloudavenue_alb_pool Mar 30, 2023
@gaetanars gaetanars force-pushed the 220-new-resource-cloudavenue_alb_pool branch from 9468903 to ff0991c Compare March 31, 2023 14:23
@gaetanars gaetanars marked this pull request as ready for review March 31, 2023 14:24
@gaetanars gaetanars requested a review from eremid March 31, 2023 14:25
azrod
azrod reviewed Mar 31, 2023
View reviewed changes
internal/provider/alb/pool_common.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_common.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_common.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_schema.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_schema.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_resource.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_resource.go Show resolved Hide resolved
internal/provider/alb/pool_resource.go Outdated Show resolved Hide resolved
internal/provider/common/org/edgegw.go Outdated Show resolved Hide resolved
internal/provider/common/org/edgegw.go Outdated Show resolved Hide resolved
@crown-app crown-app bot added the Fix label Mar 31, 2023
@gaetanars gaetanars requested a review from azrod March 31, 2023 19:47
@gaetanars gaetanars force-pushed the 220-new-resource-cloudavenue_alb_pool branch from fed743d to 13dffac Compare April 3, 2023 12:23
@crown-app crown-app bot added the Chore label Apr 3, 2023
dmicheneau
dmicheneau previously requested changes Apr 3, 2023
View reviewed changes
internal/provider/alb/pool_common.go Outdated Show resolved Hide resolved
internal/provider/common/edgegw/edgegw.go Outdated Show resolved Hide resolved
internal/provider/common/edgegw/edgegw.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_resource.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_resource.go Outdated Show resolved Hide resolved
@gaetanars gaetanars force-pushed the 220-new-resource-cloudavenue_alb_pool branch from dbec2df to 9c0557f Compare April 3, 2023 16:11
@gaetanars gaetanars requested review from dmicheneau and azrod April 3, 2023 16:13
eremid
eremid approved these changes Apr 3, 2023
View reviewed changes
internal/provider/alb/pool_datasource.go Outdated Show resolved Hide resolved
internal/tests/alb/pool_resource_test.go Outdated Show resolved Hide resolved
internal/tests/alb/pool_resource_test.go Outdated Show resolved Hide resolved
internal/tests/alb/pool_resource_test.go Outdated Show resolved Hide resolved
azrod
azrod reviewed Apr 3, 2023
View reviewed changes
internal/provider/alb/pool_datasource.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_resource.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_resource.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_resource.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_schema.go Outdated Show resolved Hide resolved
internal/provider/alb/pool_schema.go Outdated Show resolved Hide resolved
@gaetanars gaetanars merged commit 1fba795 into main Apr 4, 2023
@gaetanars gaetanars deleted the 220-new-resource-cloudavenue_alb_pool branch April 4, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azrod azrod azrod approved these changes

@eremid eremid eremid approved these changes

@dmicheneau dmicheneau Awaiting requested review from dmicheneau

Assignees
No one assigned
Labels
Chore Feature Fix size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Resource]: cloudavenue_alb_pool
4 participants
@gaetanars @eremid @azrod @dmicheneau