Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringIO.set_encoding_by_bom() #3632

Closed
rurounijones opened this issue Jul 26, 2024 · 2 comments
Closed

StringIO.set_encoding_by_bom() #3632

rurounijones opened this issue Jul 26, 2024 · 2 comments

Comments

@rurounijones
Copy link

rurounijones commented Jul 26, 2024

Some of our code makes use of this method: https://ruby-doc.org/3.2.2/exts/stringio/StringIO.html#method-i-set_encoding_by_bom

This fails in our test suite when running TruffleRuby 24.0.2

     NoMethodError:
       undefined method `set_encoding_by_bom' for #<StringIO:0x848638>

This does not appear to be implemented in Truffleruby butset_encoding is :

def set_encoding(external, internal = nil, options = nil)

(As a sidenote: Love what you guys are doing with TruffleRuby; excited for the future)

@andrykonchin
Copy link
Member

Thank you for the report, we'll look into it.

@andrykonchin andrykonchin self-assigned this Jul 26, 2024
@rurounijones rurounijones changed the title MRI Compatibility: StringIO.set_encoding_by_bom() MRI Compatibility: StringIO.set_encoding_by_bom() Jul 30, 2024
@rurounijones rurounijones changed the title MRI Compatibility: StringIO.set_encoding_by_bom() StringIO.set_encoding_by_bom() Jul 30, 2024
@andrykonchin
Copy link
Member

Fixed in 61396dc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants