Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for jigsaw service loading problem with webserver. #99

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

tomas-langer
Copy link
Member

Service loading must be done from the module that uses the service in module system. Delegating to a class in common module broke this.
Fixed this, deprecated common SpiHelper method and moved webserver loading to the same module.

@tomas-langer tomas-langer self-assigned this Oct 6, 2018
@tomas-langer tomas-langer requested a review from spericas October 6, 2018 20:16
@tomas-langer tomas-langer merged commit 25bb7a1 into helidon-io:master Oct 8, 2018
@tomas-langer tomas-langer deleted the jigsaw-fix branch November 13, 2018 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants