Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE Metrics Guide #974

Merged
merged 16 commits into from
Sep 9, 2019
Merged

SE Metrics Guide #974

merged 16 commits into from
Sep 9, 2019

Conversation

pfmackin
Copy link
Contributor

This is the SE Metrics Guide. It has several examples that demonstrate how to use Helidon metrics for a Helidon SE based application.

Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Same general comment as the MP Metrics guide. The guide currently uses the MicroProfile Metrics 1.x APIs. Shortly we will have the 2.x APIs. If possible it would be nice if the guide worked for both (by avoiding APIs that changed). I'm not sure if that's practical. We'll need feedback from @tjquinno or @spericas

docs/src/main/docs/guides/09_metrics_se_guide.adoc Outdated Show resolved Hide resolved
barchetta
barchetta previously approved these changes Sep 9, 2019
@barchetta barchetta merged commit 2930c4c into helidon-io:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants