-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MP OpenAPI support to Helidon MP #712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses - primarily for MP extension later given that SE OpenAPI support will not include annotations
Merge with concurrent changes to master.
…scaping the opening methods in case of errors
Combine with parallel unrelated changes.
Get concurrent changes.
…peline so temporarily giving up
…OpenAPI model reader and filter
Merge with concurrent changes to master.
tjquinno
requested review from
ljnelson,
romain-grecourt,
batsatt and
tomas-langer
May 20, 2019 14:34
ljnelson
requested changes
May 20, 2019
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/IndexBuilder.java
Show resolved
Hide resolved
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/IndexBuilder.java
Show resolved
Hide resolved
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/IndexBuilder.java
Outdated
Show resolved
Hide resolved
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/IndexBuilder.java
Show resolved
Hide resolved
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/IndexBuilder.java
Outdated
Show resolved
Hide resolved
openapi/src/main/java/io/helidon/openapi/internal/OpenAPIConfigImpl.java
Show resolved
Hide resolved
ljnelson
previously approved these changes
May 20, 2019
ljnelson
previously approved these changes
May 20, 2019
spericas
previously approved these changes
May 21, 2019
romain-grecourt
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds MP OpenAPI support to our MP server.
General areas of change:
The MP OpenAPI support leverages much of the work already done for support in SE. A key difference is support for endpoints annotated with OpenAPI annotations. We layer on SmallRye's OpenAPI implementation, which requires a Jandex index of annotated types. Our support looks for and uses the
META-INF/jandex.idx
file if it exists on the class path. (This is the normal, preferred case in which the developer uses the Jandex maven plug-in to create the index and packages it into the app.) Otherwise, our OpenAPI support creates a Jandex index in-memory during app start-up by registering a CDI portable extension and recording each annotated type CDI processes.Signed-off-by: Tim Quinn [email protected]