Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MP OpenAPI support to Helidon MP #712

Merged
merged 49 commits into from
May 21, 2019
Merged

Add MP OpenAPI support to Helidon MP #712

merged 49 commits into from
May 21, 2019

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented May 20, 2019

This PR adds MP OpenAPI support to our MP server.

General areas of change:

  1. Refactoring of SE OpenAPI support to reuse code common to SE and MP easily.
  2. Some minor changes to our Arquillian deployable container.
  3. Addition of the Helidon MP OpenAPI maven project under the MP project; it is also now part of the MP bundle.
  4. Addition of the OpenAPI TCK runner project.

The MP OpenAPI support leverages much of the work already done for support in SE. A key difference is support for endpoints annotated with OpenAPI annotations. We layer on SmallRye's OpenAPI implementation, which requires a Jandex index of annotated types. Our support looks for and uses the META-INF/jandex.idx file if it exists on the class path. (This is the normal, preferred case in which the developer uses the Jandex maven plug-in to create the index and packages it into the app.) Otherwise, our OpenAPI support creates a Jandex index in-memory during app start-up by registering a CDI portable extension and recording each annotated type CDI processes.

Signed-off-by: Tim Quinn [email protected]

tjquinno added 30 commits April 4, 2019 16:55
…ses - primarily for MP extension later given that SE OpenAPI support will not include annotations
Merge with concurrent changes to master.
…scaping the opening methods in case of errors
Combine with parallel unrelated changes.
Merge with concurrent changes to master.
@tjquinno tjquinno added this to the 1.1 milestone May 20, 2019
@tjquinno tjquinno self-assigned this May 20, 2019
@tjquinno tjquinno requested a review from spericas May 20, 2019 16:21
ljnelson
ljnelson previously approved these changes May 20, 2019
ljnelson
ljnelson previously approved these changes May 20, 2019
spericas
spericas previously approved these changes May 21, 2019
@tjquinno tjquinno dismissed stale reviews from spericas and ljnelson via bbffafb May 21, 2019 17:54
@tjquinno tjquinno merged commit c203cec into helidon-io:master May 21, 2019
@tjquinno tjquinno deleted the add-openapi-mp branch May 21, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants