-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document migration from 2.x to 3.x cleanup #4623
Merged
ljamen
merged 28 commits into
helidon-io:helidon-3.x
from
dalexandrov:4327_Document_migration_from_2.x_to_3.x
Aug 10, 2022
Merged
Document migration from 2.x to 3.x cleanup #4623
ljamen
merged 28 commits into
helidon-io:helidon-3.x
from
dalexandrov:4327_Document_migration_from_2.x_to_3.x
Aug 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Daniel suggestion Co-authored-by: Daniel Kec <[email protected]>
Apply Daniel suggestion Co-authored-by: Daniel Kec <[email protected]>
Final cleanup!
Resolves #4622 |
ljamen
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requested changes look good to me. I also checked the other review comments to make sure they were resolved.
@dalexandrov can you please do a local build and give me the error output? I can fix the issues through a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up and update migration document
Resolves #4327