Update/Reformat Helidon MP and SE gRPC documents #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verdent
previously requested changes
Jul 19, 2022
grpc/core/src/main/java/io/helidon/grpc/core/GrpcTlsDescriptor.java
Outdated
Show resolved
Hide resolved
grpc/client/src/main/java/io/helidon/grpc/client/GrpcChannelDescriptor.java
Outdated
Show resolved
Hide resolved
grpc/client/src/main/java/io/helidon/grpc/client/GrpcChannelDescriptor.java
Outdated
Show resolved
Hide resolved
grpc/core/src/main/java/io/helidon/grpc/core/GrpcTlsDescriptor.java
Outdated
Show resolved
Hide resolved
grpc/core/src/main/java/io/helidon/grpc/core/GrpcTlsDescriptor.java
Outdated
Show resolved
Hide resolved
grpc/server/src/main/java/io/helidon/grpc/server/GrpcServerConfiguration.java
Outdated
Show resolved
Hide resolved
… gRPC config document
arjav-desai
approved these changes
Jul 19, 2022
klustria
dismissed
Verdent’s stale review
David is already offline being from different TZ, but has already done initial review. All his comments were already resolved and reviewed by Arjav
This was referenced Jul 21, 2022
Closed
romain-grecourt
pushed a commit
to MadsBrun/helidon
that referenced
this pull request
Jul 21, 2022
* Update/Reformat Helidon MP and SE gRPC documents * Update @ConfiguredOption(s) and grpcserver paramter to grpc in the SE gRPC config document
ljamen
reviewed
Jul 27, 2022
klustria
added a commit
to klustria/helidon
that referenced
this pull request
Aug 12, 2022
Note: Feedback from helidon-io#4569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.