Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fine-tuning of metrics and OpenAPI doc updates #4563

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Some fine-tuning of metrics and OpenAPI doc updates #4563

merged 1 commit into from
Jul 18, 2022

Conversation

tjquinno
Copy link
Member

A few minor but important improvements to metrics and OpenAPI doc updates.

@tjquinno tjquinno self-assigned this Jul 17, 2022
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions but basically LGTM

* Implementations of the Helidon metrics API.
+
Helidon provides two and selects which one to use at runtime,
Helidon provides two--minimal and full-featured--and selects which one to use at runtime,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Technical writing-wise: I always like numbered lists, even for short lists.)

1. Edit your `pom.xml`.
2. Furnish OpenAPI information about your application's endpoints.
3. Update your application's configuration (optional).
1. Furnish OpenAPI information about your application's endpoints.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "provide" rather than "furnish" for non-native speakers, not sure.

@tjquinno tjquinno merged commit c538b6a into helidon-io:master Jul 18, 2022
@tjquinno tjquinno deleted the docs-fine-tune branch July 18, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants