Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence documentation #4561

Merged
merged 168 commits into from
Jul 19, 2022
Merged

Conversation

ljnelson
Copy link
Member

Adds documentation for named data sources, JTA and JPA integrations.

@ljnelson ljnelson added docs P1 jpa/jta 3.x Issues for 3.x version branch labels Jul 16, 2022
@ljnelson ljnelson requested review from barchetta and ljamen July 16, 2022 00:54
@ljnelson ljnelson self-assigned this Jul 16, 2022
@ljnelson ljnelson linked an issue Jul 16, 2022 that may be closed by this pull request
8 tasks
@ljnelson ljnelson marked this pull request as ready for review July 18, 2022 03:25
m0mus
m0mus previously approved these changes Jul 18, 2022
Copy link
Contributor

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When build issues are fixed it can be merged.

@m0mus m0mus added this to the 3.0.0 milestone Jul 18, 2022
@ljnelson ljnelson requested a review from m0mus July 18, 2022 17:49
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting this PR would removedocs/mp/extensions/cdi-datasource*.adoc and cdi-jta.adoc

@ljnelson ljnelson marked this pull request as draft July 18, 2022 20:33
@ljnelson ljnelson force-pushed the datasource-documentation branch from 7aa03a7 to 4c48a66 Compare July 18, 2022 20:34
@ljnelson ljnelson marked this pull request as ready for review July 18, 2022 22:43
@ljnelson
Copy link
Member Author

@barchetta per our conversation, removed various things and readjusted menus etc. appropriately to address your comment above. @romain-grecourt I believe I've resolved all your comments. mvn site -N builds locally.

ljnelson added 7 commits July 18, 2022 20:18
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
ljnelson added 16 commits July 18, 2022 20:18
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson ljnelson force-pushed the datasource-documentation branch from 5a6319c to 8fde71a Compare July 19, 2022 03:19
Signed-off-by: Laird Nelson <[email protected]>
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments + left-over occurrences of http://h2database.com (https://)

docs/includes/attributes.adoc Outdated Show resolved Hide resolved
docs/includes/attributes.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
Signed-off-by: Laird Nelson <[email protected]>
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left-over occurrences of http://www.h2database.com ; plain http:// links trigger warnings all over ; that includes IntelliJ and a certain corporate tool.

docs/mp/persistence.adoc Outdated Show resolved Hide resolved
docs/mp/persistence.adoc Outdated Show resolved Hide resolved
@ljnelson ljnelson merged commit d801464 into helidon-io:master Jul 19, 2022
@ljnelson ljnelson deleted the datasource-documentation branch July 19, 2022 23:28
romain-grecourt added a commit to MadsBrun/helidon that referenced this pull request Jul 21, 2022
Adds persistence-related documentation

Signed-off-by: Laird Nelson <[email protected]>
Co-authored-by: Romain Grecourt <[email protected]>
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we can split this up or change the structure a bit to flatten the headings?

your relational database vendor's JDBC driver.

How you set up Helidon MP's named data source integration differs
depending on which of these two connection pools, which JDBC driver,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depending on the connection pool, JDBC driver and relational database products you use.

and which relational database product you use.

Representative setups are described below. The list of such setups is
not exhaustive.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For more information, see .... (?)


===== Setting up the Oracle Universal Connection Pool [[DS-UCP-Project-Setup]]

====== Maven Coordinates (Oracle Universal Connection Pool) [[DS-UCP-Maven-Coordinates]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc:] Helidon MP Persistence
5 participants