Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebClient documentation #4517

Merged
merged 9 commits into from
Jul 19, 2022

Conversation

Verdent
Copy link
Member

@Verdent Verdent commented Jul 12, 2022

Bound issue: #4313

@Verdent Verdent self-assigned this Jul 12, 2022
@Verdent Verdent added the docs label Jul 12, 2022
@Verdent Verdent requested review from ljamen and tomas-langer July 12, 2022 16:08
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small updates, LGTM.

docs/se/webclient/introduction.adoc Outdated Show resolved Hide resolved
docs/se/webclient/introduction.adoc Outdated Show resolved Hide resolved
docs/se/webclient/introduction.adoc Outdated Show resolved Hide resolved
@romain-grecourt romain-grecourt marked this pull request as draft July 14, 2022 18:58
@Verdent Verdent force-pushed the webclient-documentation-latest branch 2 times, most recently from acc0961 to e12bb1c Compare July 15, 2022 12:39
@m0mus m0mus marked this pull request as ready for review July 15, 2022 12:48
docs/se/webclient.adoc Outdated Show resolved Hide resolved
@Verdent Verdent force-pushed the webclient-documentation-latest branch from 1ba6768 to 17bdecd Compare July 15, 2022 14:09
@m0mus m0mus dismissed tomas-langer’s stale review July 18, 2022 09:18

All review comments are addressed

m0mus
m0mus previously approved these changes Jul 18, 2022
Verdent added 9 commits July 19, 2022 09:58
Signed-off-by: David Kral <[email protected]>
Signed-off-by: David Kral <[email protected]>
Signed-off-by: David Kral <[email protected]>
Signed-off-by: David Kral <[email protected]>
Signed-off-by: David Kral <[email protected]>
Signed-off-by: David Kral <[email protected]>
Signed-off-by: David Kral <[email protected]>
Signed-off-by: David Kral <[email protected]>
@Verdent Verdent force-pushed the webclient-documentation-latest branch from 17bdecd to 120c631 Compare July 19, 2022 08:01
@Verdent Verdent merged commit a981c4d into helidon-io:master Jul 19, 2022
romain-grecourt pushed a commit to MadsBrun/helidon that referenced this pull request Jul 21, 2022
WebClient documentation

Signed-off-by: David Kral <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants