Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New formatting for Helidon Health Checks SE document #4495

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

spericas
Copy link
Member

@spericas spericas commented Jul 8, 2022

Signed-off-by: Santiago Pericasgeertsen [email protected]

@spericas spericas added this to the 3.0.0 milestone Jul 8, 2022
@spericas spericas requested a review from ljamen July 8, 2022 16:04
@spericas spericas self-assigned this Jul 8, 2022
@spericas spericas requested a review from romain-grecourt July 11, 2022 13:56
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just small comments. I need to check the template re: the casing.

docs/se/health.adoc Outdated Show resolved Hide resolved
docs/se/health.adoc Outdated Show resolved Hide resolved
@spericas spericas requested a review from ljamen July 11, 2022 18:12
@spericas spericas added the 3.x Issues for 3.x version branch label Jul 12, 2022
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas merged commit d14d6f9 into helidon-io:master Jul 13, 2022
romain-grecourt pushed a commit to MadsBrun/helidon that referenced this pull request Jul 21, 2022
* New formatting for Helidon Health Checks SE document.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>

* Incorporated suggested stylistic changes. Fixed references to new health doc.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch docs health SE
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants