Helidon MP Health new style documentation #4387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerated config adoc.
m0mus
reviewed
Jun 15, 2022
m0mus
reviewed
Jun 15, 2022
m0mus
reviewed
Jun 15, 2022
m0mus
reviewed
Jun 15, 2022
m0mus
reviewed
Jun 15, 2022
m0mus
reviewed
Jun 15, 2022
m0mus
reviewed
Jun 15, 2022
docs/mp/health/01_introduction.adoc
Outdated
| No additional information provided |
There was a problem hiding this comment.
I would delete the whole "Additional Information" section if its empty.
There was a problem hiding this comment.
Added information.
There was a problem hiding this comment.
Although a link to microprofile.io could be useful, it's more useful to add links to MP Health 4.0 and MP Health API repository.
There was a problem hiding this comment.
There is already a link in the Usage description. Should it be duplicated here?
There was a problem hiding this comment.
Added info to Reference
There was a problem hiding this comment.
Can you add a link to Health javadocs?
docs/shared/config/io.helidon.health.HealthSupport.Builder.adoc
Outdated
Show resolved
Hide resolved
tomas-langer
requested changes
Jun 17, 2022
tomas-langer
requested changes
Jun 17, 2022
tomas-langer
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helidon MP Health new style documentation.
Include generated configuration adoc.
Resolves #4194