Fix JwtProvider wrong error message for Helidon 3.x #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
requested changes
Apr 20, 2022
security/providers/jwt/src/main/java/io/helidon/security/providers/jwt/JwtProvider.java
Outdated
Show resolved
Hide resolved
|
Hi, I logged the original bug. I don't think the proposed fix is right. It should be "return failOrAbstain(validate.toString());" , not "errors.toString()". At that point it needs to report the errors from the "Errors validate = jwt.validate(null, expectedAudience)" call (not from the Errors errors = signedJwt.verifySignature(verifyKeys, defaultJwk) call ). Thanks. |
|
Ah, you are right! Thank you :) |
tomas-langer
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed with @arjav-desai, the current message is wrong. There is already
Jwt#addAudienceValidatorfunction, where audience is validated. We can rely on its messages.Resolves #3912 for Helidon 3.x