Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special treatment for ParamConverterProviders with multiple apps (master) #3857

Merged
merged 4 commits into from
Feb 2, 2022

Conversation

spericas
Copy link
Member

@spericas spericas commented Feb 1, 2022

  • Special treatment for ParamConverterProviders. They are now all registered in the shared injection manager when more than one application is present. This ensures they are all properly installed; otherwise, Jersey will only consider those known after the first of the applications is registered.

Signed-off-by: Santiago Pericasgeertsen [email protected]

  • Updated copyright year.

Signed-off-by: Santiago Pericasgeertsen [email protected]

  • New approach that calls getClasses/getSingletons and does require finding ParamConverterProviders via class scanning.

Signed-off-by: Santiago Pericasgeertsen [email protected]

  • Restore ExceptionMapper registration statement.

Signed-off-by: Santiago Pericasgeertsen [email protected]

  • Fixed support for singletons and additional testing.

Signed-off-by: Santiago Pericasgeertsen [email protected]

…idon-io#3846)

* Special treatment for ParamConverterProviders. They are now all registered in the shared injection manager when more than one application is present. This ensures they are all properly installed; otherwise, Jersey will only consider those known after the first of the applications is registered.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>

* Updated copyright year.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>

* New approach that calls getClasses/getSingletons and does require finding ParamConverterProviders via class scanning.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>

* Restore ExceptionMapper registration statement.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>

* Fixed support for singletons and additional testing.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>
@spericas spericas added webserver jax-rs JAX-RS and Jersey related issues labels Feb 1, 2022
@spericas spericas added this to the 3.0.0-M1 milestone Feb 1, 2022
@spericas spericas requested a review from tjquinno February 1, 2022 19:32
@spericas spericas self-assigned this Feb 1, 2022
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
tjquinno
tjquinno previously approved these changes Feb 1, 2022
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
@spericas spericas merged commit eb365be into helidon-io:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jax-rs JAX-RS and Jersey related issues webserver
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants