Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3640 Netty mixed writing (#3671) #3679

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

danielkec
Copy link
Contributor

@danielkec danielkec commented Nov 30, 2021

Fixes #3640

  • Execute writes on event-loop thread only

Signed-off-by: Daniel Kec [email protected]

* Execute writes on event-loop thread only

Signed-off-by: Daniel Kec <[email protected]>
@danielkec danielkec force-pushed the 3640-netty-mixed-writing branch from c5e6156 to 7bce804 Compare November 30, 2021 20:55
@danielkec danielkec added this to the 3.0.0 milestone Nov 30, 2021
spericas
spericas previously approved these changes Dec 9, 2021
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Daniel Kec <[email protected]>
@danielkec danielkec merged commit 2433d98 into helidon-io:master Dec 9, 2021
arjav-desai pushed a commit to arjav-desai/helidon that referenced this pull request Dec 17, 2021
* 3640 Netty mixed writing (helidon-io#3671)

* Execute writes on event-loop thread only

Signed-off-by: Daniel Kec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server: Broken order of Netty writes
2 participants