Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare RegistryFactory lazily to use the most-recently-assigned MetricsSettings (3.0) #3661

Merged
merged 3 commits into from
Nov 18, 2021
Merged

Prepare RegistryFactory lazily to use the most-recently-assigned MetricsSettings (3.0) #3661

merged 3 commits into from
Nov 18, 2021

Conversation

tjquinno
Copy link
Member

Resolves #3660

See PR #3659 (2.x) for explanation

…val so as to use the latest-provided MetricsSettings
…with the correct MetricsSettings before the producer 'clearApplicationRegistry' method is invoked
@tjquinno tjquinno added this to the 3.0.0 milestone Nov 18, 2021
@tjquinno tjquinno self-assigned this Nov 18, 2021
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno merged commit f8ee8ea into helidon-io:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling metrics with full-featured metrics on runtime path does not work (3.0)
2 participants