Upgrade Jaeger to align with opentracing version. #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkec
previously approved these changes
Sep 16, 2020
barchetta
reviewed
Sep 16, 2020
Signed-off-by: Tomas Langer <[email protected]>
Signed-off-by: Tomas Langer <[email protected]>
tomas-langer
force-pushed
the
jaeger-version
branch
from
5ef89f5 to
b9a2440
Compare
danielkec
previously approved these changes
Sep 17, 2020
barchetta
reviewed
Sep 17, 2020
There was a problem hiding this comment.
Looks like 0.35.X pulls in Apache Thrift 0.12.0 which has a CVE (CVE-2019-0205). Can we manage the thrift dependency and force it to version 0.13.0 (has Java client fix for the CVE)? Note we don't have this issue in Helidon 2.X because later versions of Jaeger tracing client upgraded to Thrift 0.13.0.
Signed-off-by: Tomas Langer <[email protected]>
|
Added dependency management for Apache Thrift to use a newer version with Jaeger than the default. |
barchetta
reviewed
Sep 21, 2020
Signed-off-by: Tomas Langer <[email protected]>
barchetta
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomas Langer [email protected]
Fixes #1315