Changes default logging to write to System.out. #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljnelson
approved these changes
Nov 15, 2019
| /** | ||
| * Logging handler that writes to {@link System#out} and uses a formatter that will replace {@code "!thread!"} substrings | ||
| * with the current thread. | ||
| */ |
There was a problem hiding this comment.
How about: "A {@link StreamHandler} that writes to {@linkplain System#out standard out} and uses a {@link ThreadFormatter} for formatting purposes."
And: "@see ThreadFormatter". Assuming it becomes public of course.
| public class HelidonConsoleHandler extends StreamHandler { | ||
|
|
||
| /** | ||
| * Constructor. |
There was a problem hiding this comment.
How about: "Creates a new {@link HelidonConsoleHandler}."
| setFormatter(new ThreadFormatter()); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Probably worth documenting what you do in this method.
| flush(); | ||
| } | ||
|
|
||
| @Override |
| flush(); | ||
| } | ||
|
|
||
| private static class ThreadFormatter extends SimpleFormatter { |
There was a problem hiding this comment.
This seems like a useful class in general; perhaps make it public?
batsatt
requested review from
ljnelson and
tomas-langer
and removed request for
tomas-langer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1144.
Note that by setting the level in the handler to
Level.ALL,the only levels that matter are those on the loggers, which is what nearly everyone expects.