Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw JsonException when parser returns unexpected type #1085

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

spericas
Copy link
Member

@spericas spericas commented Oct 8, 2019

Verify that the type returned by the JSON-P parser matches that requested by the application, and if does not, throw a JsonException instead of a low-level ClassCastException. See issue #991.

Signed-off-by: Santiago Pericas-Geertsen [email protected]

…t requested by the application, and if does not, throw a JsonException instead of a low-level ClassCastException. See helidon-io#991.

Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
@spericas spericas self-assigned this Oct 8, 2019
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas merged commit d320850 into helidon-io:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants