Fix for issue #1070 #1074
Merged
Fix for issue #1070 #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… injection point configuration to avoid adding duplicate producers for inherited fields. Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem is in
ConfigCdiExtension, in the way it handles registration of producers for injection points. Whenever there is inheritance, the same field (in different classes) is discovered more than once and each discovery results in a new producer being created.This PR uses a set instead of a list to collect injection point configuration to avoid adding duplicate producers for inherited fields. A new test has been added to verify the changes.
This is a WIP.
Signed-off-by: Santiago Pericas-Geertsen [email protected]