Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MpcSourceEnvironmentVariablesTest::testPrecedence fails on Windows #636

Closed
Verdent opened this issue May 2, 2019 · 2 comments · Fixed by #641
Closed

MpcSourceEnvironmentVariablesTest::testPrecedence fails on Windows #636

Verdent opened this issue May 2, 2019 · 2 comments · Fixed by #641
Assignees
Labels
bug Something isn't working config P1

Comments

@Verdent
Copy link
Member

Verdent commented May 2, 2019

When you run following test MpcSourceEnvironmentVariablesTest::testPrecedence on Windows, it fails because of the value bound to the key "com.acme.size" was found in the config.

org.opentest4j.AssertionFailedError: Expected java.util.NoSuchElementException to be thrown, but nothing was thrown.
	at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:70)
	at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:38)
	at org.junit.jupiter.api.Assertions.assertThrows(Assertions.java:1155)
	at io.helidon.microprofile.config.MpcSourceEnvironmentVariablesTest.assertNoValue(MpcSourceEnvironmentVariablesTest.java:155)
	at io.helidon.microprofile.config.MpcSourceEnvironmentVariablesTest.testPrecedence(MpcSourceEnvironmentVariablesTest.java:125)
.....
@Verdent Verdent added bug Something isn't working config labels May 2, 2019
@batsatt
Copy link
Contributor

batsatt commented May 2, 2019

@Verdent Does the test pass if you comment out lines 125 and 145? It is going to take me awhile to setup an env to reproduce this; I have a fix if those are the only assertions that fail on windows.

@batsatt
Copy link
Contributor

batsatt commented May 3, 2019

I was able to setup a VirtualBox env; reproduced and verified fix.

@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working config P1
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants