Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try all available fault domains in case of out of host capacity #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Try all available fault domains in case of out of host capacity #134

wants to merge 1 commit into from

Conversation

shyamradhakrishnan
Copy link
Contributor

What this PR does / why we need it:

  1. We will pick a random FD if not specified by the user
  2. If the request results in out of host error, we will retry with other FDs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #133

@shyamradhakrishnan
Copy link
Contributor Author

unit tests

?   	github.com/oracle/cluster-api-provider-oci	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta1	0.937s	coverage: 18.7% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/config	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/ociutil	0.673s	coverage: 24.4% of statements
ok  	github.com/oracle/cluster-api-provider-oci/cloud/scope	167.488s	coverage: 73.1% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/controllers	27.931s	coverage: 71.0% of statements
?   	github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/exp/controllers	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/feature	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/version	[no test files]

@shyamradhakrishnan
Copy link
Contributor Author

e2e test

Summarizing 1 Failure:

[Fail] Workload cluster creation [AfterEach] Cloud Provider OCI testing [PRBlocking]
/home/ubuntu/go/src/github.com/oracle/cluster-api-provider-oci/vendor/sigs.k8s.io/cluster-api/test/framework/cluster_helpers.go:175

Ran 5 of 22 Specs in 2704.749 seconds
FAIL! -- 4 Passed | 1 Failed | 0 Pending | 17 Skipped


Ginkgo ran 1 suite in 45m9.415705428s

ccm test failed because of an intermittent failure, succeeded on retry

• [SLOW TEST:947.803 seconds]
Workload cluster creation
/home/ubuntu/go/src/github.com/oracle/cluster-api-provider-oci/test/e2e/cluster_test.go:50
  Cloud Provider OCI testing [PRBlocking]
  /home/ubuntu/go/src/github.com/oracle/cluster-api-provider-oci/test/e2e/cluster_test.go:202
------------------------------
STEP: Tearing down the management cluster


Ran 1 of 22 Specs in 1022.083 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 21 Skipped


Ginkgo ran 1 suite in 17m5.545088617s

@joekr joekr added the enhancement New feature or request label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekr joekr joekr approved these changes

Assignees

@shyamradhakrishnan shyamradhakrishnan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In case of out of host capacity errors, all fault domains should be tried before backoff
2 participants
@shyamradhakrishnan @joekr