Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to base module #86

Open
hyder opened this issue Apr 16, 2021 · 1 comment
Open

Add logging to base module #86

hyder opened this issue Apr 16, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@hyder
Copy link
Contributor

hyder commented Apr 16, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

We should be able to add VCN flow logs, bastion and operator logs as well as any other infra that is created on top of the base module.

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

@hyder hyder added the enhancement New feature or request label Apr 16, 2021
@kral2
Copy link

kral2 commented Apr 16, 2021

I would advice to implement log feature one level lower when composing with other modules, instead of directly in base module.

e.g: vcn module is responsible to expose inputs to enable or not its own logs, same for compute, etc.

Base module will configure this setting for each resource as needed, but could own the loggroup creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants