Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code sample - SpringBoot Hikari to UCP migration #352

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Code sample - SpringBoot Hikari to UCP migration #352

wants to merge 3 commits into from

Conversation

juarezjuniorgithub
Copy link
Member

Signed-off-by: Juarez Barbosa [email protected]
@Kuassim @jeandelavarene please review and approve. Thanks!

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 10, 2024
@juarezjuniorgithub juarezjuniorgithub mentioned this pull request May 10, 2024
Open
@gvenzl gvenzl requested a review from jeandelavarene May 17, 2024 22:11
jeandelavarene
jeandelavarene reviewed May 20, 2024
View reviewed changes
java/springboot-hikari-ucp/pom.xml Outdated
<dependency>
<groupId>com.oracle.database.jdbc</groupId>
<artifactId>ucp11</artifactId>
<version>23.3.0.23.09</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 23.4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jean, it's already using it. You're looking at a past commit, I followed all your requests. To confirm, look at commit 75a6f82

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kuassim please review, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuassim Kuassim Kuassim approved these changes

@jeandelavarene jeandelavarene Awaiting requested review from jeandelavarene

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juarezjuniorgithub @Kuassim @jeandelavarene