Fixes for recently merged helpers #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cpuhp_state variable doesn't exist in UEK4 - this is fine, just ignore it. Strangely, dump_stack_arch_desc_str doesn't seem to exist on UEK6 CTF vmcores. This is almost certainly a CTF generation issue, since it is present on UEK7 and UEK5 vmcores. Fortunately, the type is simple (char[128]) and unlikely to change. For now, it can be hard coded. Signed-off-by: Stephen Brennan <[email protected]>
This patch was provided by Praveen to fix an issue in the "net" module. It is lightly edited to fix formatting issues detected by pre-commit. Signed-off-by: Stephen Brennan <[email protected]> Authored-by: Praveen Kumar Kannoju <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
When 5-level paging is enabled, VMALLOC_SIZE_TB is much larger (see pgtable_64_types.h as cited in the code). This fixes test failures with CTF on live kernels (since this is the only way that we can compare against the real /proc/meminfo). Sadly, Gitlab is not currently running live CTF tests, so I only found this during RPM release prep for drgn. CTF testing is definitely possible for the heavy VM tests, all that is necessary is to get it up and running. This helps reveal the need for it. Signed-off-by: Stephen Brennan <[email protected]>
|
Added one more fix for VmallocTotal with 5-level paging. |
biger410
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtutil module contained some test failures:
cpuhp_statevariable, handle it gracefullyThe net module was missing some changes that had been applied as part of the code review, introduce them here.