Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node-fetch to v3 #96

Open
giordano opened this issue Jan 31, 2022 · 2 comments · May be fixed by #97
Open

Upgrade node-fetch to v3 #96

giordano opened this issue Jan 31, 2022 · 2 comments · May be fixed by #97
Labels
technical Related to VSCode, packaging etc rather than usage

Comments

@giordano
Copy link
Collaborator

We're currently using node-fetch v2.6.7, but v3 was released a few months ago. We may want to use the latest version. #92 already tried to upgrade to v3 but tests failed, so we may need manual intervention to deal with the new major version (reasonable since v3 is a breaking change compared to v2). Here are the upgrade instructions.

@giordano giordano added the technical Related to VSCode, packaging etc rather than usage label Jan 31, 2022
@ageorgou
Copy link
Contributor

The error appears to be linked to producing (old style) require statements instead of (newer style) import. In v3 of node-fetch, only the latter is supported. Our Typescript code uses import but it seems to be compiled down to require in the actual Javascript. It looks like we need some changes to our config files to force the switch (and possibly our other import statements).

@ageorgou ageorgou linked a pull request Jan 31, 2022 that will close this issue
@giordano
Copy link
Collaborator Author

giordano commented May 9, 2022

James reported:

Experimental support for the fetch api is now in Node.js version 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Related to VSCode, packaging etc rather than usage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants