Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting is called too many times #383

Open
giordano opened this issue May 30, 2019 · 0 comments
Open

Syntax highlighting is called too many times #383

giordano opened this issue May 30, 2019 · 0 comments

Comments

@giordano
Copy link
Contributor

giordano commented May 30, 2019

We should probably rationalise the calls to SyntaxHighlighter.syntax_highlight(): when a file is opened, it's highlighted several times. All of them comes from runSwingLater(NammuController.initHighlighting). In particular:

  • for an English-only file, two calls come from AtfEditArea.setText, and one from NammuController.openFile
  • for a file with Arabic translation, two calls come from AtfEditArea.setText, one from NammuController.openFile, and six from atfAreaAdjustmentListener.adjustmentValueChanged

It's possible that, e.g., NammuController.openFile itself is calling AtfEditArea.setText, I'm counting the calling places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant