Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not exiting properly #373

Open
ageorgou opened this issue Apr 12, 2019 · 0 comments
Open

Tests not exiting properly #373

ageorgou opened this issue Apr 12, 2019 · 0 comments
Labels

Comments

@ageorgou
Copy link
Contributor

In the last few days, we have noticed that pytest does not exit even after finishing all the tests and printing the report. This also means that sometimes Travis fails due to timing out, even if all the tests pass. The same also happens on local development setups, so it doesn't look like a Travis problem.

This doesn't happen consistently, but it seems to have become more frequent in the last week, so it might be related to recent changes, somewhere between da1f29b and f299dd2. Changing the NammuController to a pytest-style fixture (afe0835) didn't seem to make much difference.

It may be that Nammu spawns some other process or component that is not always properly deleted, hence letting pytest wait. This link could have some solutions for ensuring that all Swing components are destroyed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant