From 4bb76da627bc31a1806370803bf15e4ede2fc5e4 Mon Sep 17 00:00:00 2001 From: porink0424 Date: Fri, 31 May 2024 09:22:14 +0900 Subject: [PATCH 1/4] Add type-check on standalone_app as run script --- standalone_app/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/standalone_app/package.json b/standalone_app/package.json index a9f26a7f3..935efeddc 100644 --- a/standalone_app/package.json +++ b/standalone_app/package.json @@ -5,7 +5,8 @@ "description": "", "scripts": { "watch": "vite", - "build:vscode": "webpack" + "build:vscode": "webpack", + "type-check": "tsc --noEmit" }, "devDependencies": { "@optuna/types": "../tslib/types", From 994587f96683956276c5619a216ae0c2475757b3 Mon Sep 17 00:00:00 2001 From: porink0424 Date: Fri, 31 May 2024 09:22:50 +0900 Subject: [PATCH 2/4] Add running type-check in typescript-tests workflow --- .github/workflows/typescript-tests.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/typescript-tests.yml b/.github/workflows/typescript-tests.yml index 90f766452..db8de580d 100644 --- a/.github/workflows/typescript-tests.yml +++ b/.github/workflows/typescript-tests.yml @@ -29,7 +29,7 @@ jobs: - run: npm run lint type-check: - name: Type checking on optuna-dashboard + name: Type checking on optuna-dashboard & standalone_app runs-on: ubuntu-latest steps: @@ -44,11 +44,17 @@ jobs: - name: Setup tslib run: make tslib - - name: Type Check + - name: Type Check optuna_dashboard working-directory: optuna_dashboard run: | npm install npm run type-check + + - name: Type Check standalone_app + working-directory: standalone_app + run: | + npm install + npm run type-check check-package-lock-json: name: Check package-lock.json From 4f19f44318c724a39a2d90b2070698638c1c9c02 Mon Sep 17 00:00:00 2001 From: porink0424 Date: Fri, 31 May 2024 10:46:51 +0900 Subject: [PATCH 3/4] Add building rustlib process before type-check for standalone_app --- .github/workflows/typescript-tests.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/typescript-tests.yml b/.github/workflows/typescript-tests.yml index db8de580d..5ac1c701f 100644 --- a/.github/workflows/typescript-tests.yml +++ b/.github/workflows/typescript-tests.yml @@ -49,7 +49,11 @@ jobs: run: | npm install npm run type-check - + + - name: Build rustlib for standalone_app + working-directory: rustlib + run: wasm-pack build --target web + - name: Type Check standalone_app working-directory: standalone_app run: | From da5f81d8b4d1f6e8d0528d17e6e2606a0f647f6b Mon Sep 17 00:00:00 2001 From: porink0424 Date: Fri, 31 May 2024 10:52:42 +0900 Subject: [PATCH 4/4] Install wasm-pack before building rustlib --- .github/workflows/typescript-tests.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/typescript-tests.yml b/.github/workflows/typescript-tests.yml index 5ac1c701f..5593f52ab 100644 --- a/.github/workflows/typescript-tests.yml +++ b/.github/workflows/typescript-tests.yml @@ -52,7 +52,9 @@ jobs: - name: Build rustlib for standalone_app working-directory: rustlib - run: wasm-pack build --target web + run: | + curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh + wasm-pack build --target web - name: Type Check standalone_app working-directory: standalone_app