[FSSDK-10665] fix: Github Actions YAML files vulnerable to script injections corrected #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikechu-optimizely
approved these changes
Sep 23, 2024
|
@FarhanAnjum-opti I'm researching the CI test error... |
muzahidul-opti
changed the title
muzahidul-opti
changed the title
|
Great to see your first PR being reviewed! I made a few small updates to the title and description. |
CI error similar to nunit/nunit3-vs-adapter#1049
v3.18.2 introduced an incompatibility
|
@FarhanAnjum-opti I finally fixed the problem with CI. You're welcome to squash+merge when you're ready. |
FarhanAnjum-opti
deleted the
farhan/FSSDK-10665-github-actions-correction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of directly using variables that can contain user input, new intermediate variables were introduced so that script injection attacks could be mitigated. Also removed unnecessary use of ${{ }} as using it makes the file vulnerable.
Issues