Create virtual methods on user context #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-pons
changed the title
|
can you please update it with master. |
Pull changes from source repository
…irtual Make OptimizelyUserContext members virtual, making them overridable by testing frameworks
…re to english, as for systems on others cultures, some tests were failing.
daniel-pons
force-pushed
the
daniel-pons/create-virtual-methods-on-user-context
branch
from
c770664 to
3fbdfcf
Compare
My bad, done! |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following versions of Optimizely C# SDK would use the methods defined on the class OptimizelyUserContext to perform some processes, E.G: Decide, TrackEvent, DecideAll, etc...
Then, it is required on the vast majority of unit testing frameworks, for mocking this object to be able to override such members.
This can be accomplished, at least on C#, usually in two ways:
This PR uses the second approach, it makes the methods on OptimizelyUserContext virtual.
Also fixes a problem with development environments with a culture different from English.