Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SKIPCC_* instead of #* for skipping change control in key value #191

Closed
samuelstroschein opened this issue Dec 9, 2024 — with Linear · 2 comments · Fixed by opral/monorepo#3294 or opral/monorepo#3283
Assignees
Labels

Comments

Copy link
Member

Context

We likely introduce more flags like TEMP_ in for keys. Mixing & matching keys like TEMP_SKIPCC_* (key that should not be change controlled and deleted after the session) is harder with #.

#_TEMP_username
TEMP_#_username 

Proposal

Use upper case word flags to ease future mix & matching.

SKIPCC_TEMP_username
TEMP_SKIPCC_username
Copy link
Member Author

use cases are plenty. query parameters might even be simpler.

key?temp&no_cc
lix_server_url?temp&no_sync

Copy link
Member Author

samuelstroschein commented Dec 17, 2024

another use case is global. the key is synced but global across versions.

lix_server_url?global

at this point, the options for key values become to vast. query parameters or chars as flags like # are too undiscoverable.

Proposal key_values.options

Add a JSON value for options that instruct lix how to handle the keys.

  • discoverable
  • combinable
  • doens't lead to key renames to change the options
lix.db.insertInto("key_value").values({
  key: "example",
  value: "something"
  options: {
    skip_change_control: true, 
    global: true, 
    temporary: true
  }
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant