Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS for proto ownership #3756

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

BenHenning
Copy link
Member

@BenHenning BenHenning commented Sep 1, 2021

Explanation

This splits code ownership for model & script protos. We originally intended for all protos to go into model/ per Gradle limitations, but scripts/ is Bazel-only and is demonstrating our longer-term strategy of putting protos closer to code. Ownership is being updated accordingly.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A

Move scripts protos to separate ownership.
@BenHenning BenHenning marked this pull request as ready for review September 1, 2021 18:40
@BenHenning BenHenning requested a review from a team as a code owner September 1, 2021 18:40
@BenHenning BenHenning requested a review from seanlip September 1, 2021 18:40
@BenHenning BenHenning enabled auto-merge (squash) September 1, 2021 18:43
@BenHenning
Copy link
Member Author

Thanks @seanlip!

@oppiabot
Copy link

oppiabot bot commented Sep 1, 2021

Unassigning @seanlip since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Sep 1, 2021
@oppiabot
Copy link

oppiabot bot commented Sep 1, 2021

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning BenHenning merged commit cb30f19 into develop Sep 1, 2021
@BenHenning BenHenning deleted the update-proto-codeowners branch September 1, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants