Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom CoroutineLiveData with AndroidX's CoroutineLiveData #72

Closed
BenHenning opened this issue Aug 23, 2019 · 2 comments
Closed

Replace custom CoroutineLiveData with AndroidX's CoroutineLiveData #72

BenHenning opened this issue Aug 23, 2019 · 2 comments
Assignees
@BenHenning
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

#64 introduced a custom CoroutineLiveData due to issues with AndroidX's (see PR description for details). Long-term, we do not want to ship with this custom solution as it likely has various lifecycle implications.

There's not yet a bug filed against the AndroidX team to fix this, but one will be filed soon. This issue is also tracking filing that bug, and following along with its progress until a fix is known, checked in, and released in a version of the support library we can update the codebase to.
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 23, 2019
@BenHenning BenHenning added this to the Global Availability milestone Aug 23, 2019
@BenHenning BenHenning self-assigned this Aug 23, 2019
@BenHenning
Copy link
Member Author

NB: This is blocked on the AndroidX bug that hasn't yet been filed.

Also, we may want to fix this in the prototype or MVP stages if the custom solution results in stability issues.

@BenHenning BenHenning mentioned this issue Aug 23, 2019
Merged
@BenHenning BenHenning mentioned this issue Sep 2, 2019
Closed
@BenHenning
Copy link
Member Author

I don't think we want to do this anymore since we've since introduced our own custom live data hook for coroutines that doesn't involve the MediatorLiveData solution needed to work with AndroidX's version.

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2022
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BenHenning