Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text doesn't change when using non-English languages #4394

Closed
BenHenning opened this issue Jun 16, 2022 · 5 comments · Fixed by #4411
Closed

Text doesn't change when using non-English languages #4394

BenHenning opened this issue Jun 16, 2022 · 5 comments · Fixed by #4411
Assignees
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

Describe the bug
In-lesson reading text size doesn't change when selecting different sizes when using a language other than English.

To Reproduce
Steps to reproduce the behavior:

  1. Select a non-English language at the system level (e.g. Swahili)
  2. Open a lesson and navigate to a chapter
  3. Open the options overflow and navigate to reading text size
  4. Select a text size & navigate back to the options screen
  5. Observe that the reading size (subtext) hasn't changed
  6. Navigate back to the exploration (you may need to leave and re-enter it per Text size does not change in-exploration #4285)
  7. Observe that the text size hasn't changed

Expected behavior
The reading text size should change when a new size is picked regardless of language, and should be reflected in the options screen.

Demonstration
Not including this initially, but I can if it's needed.

Environment

  • Device/emulator being used: Nexus 5X
  • Android or SDK version (e.g. Android 5 or SDK 21): 8.1.0
  • App version (you can get this through system app settings or via the admin controls menu in-app): tip-of-tree (0.8), but it probably affects all releases since internationalization was introduced (0.6 and 0.7).

Additional context
This was brought up in a discussion regarding the Kenya research project. It was assumed to be the same issue as #4285 until I accidentally stumbled upon it and realized that the feature completely breaks (vs. being awkward and needing a UI restart).

@BenHenning
Copy link
Member Author

(Adding this to the Alpha MR5 milestone since this is actually a bit important to try and fix, especially since it's hopefully relatively straightforward).

@BenHenning
Copy link
Member Author

@KolliAnitha this might indicate that we aren't testing internationalization cases in our test matrix. Are we ensuring that different features are tested (at least occasionally) with non-English?

/cc @seanlip as FYI

@BenHenning
Copy link
Member Author

/cc @isalooo and @dika1osune as FYI.

@KolliAnitha
Copy link

Hi Ben, I will add localization cases in the test matrix and ensure to cover them going forward.

@Broppia Broppia added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jul 7, 2022
@BenHenning BenHenning modified the milestones: Alpha MR5, Beta MR1 Jul 18, 2022
@BenHenning BenHenning self-assigned this Jul 18, 2022
@KolliAnitha
Copy link

User is able to change the reading text size in non-english language(Portugese) in beta version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

4 participants