Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text size updating for other screens #1540

Closed
1 of 2 tasks
anandwana001 opened this issue Jul 29, 2020 · 10 comments
Closed
1 of 2 tasks

Text size updating for other screens #1540

anandwana001 opened this issue Jul 29, 2020 · 10 comments
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@anandwana001
Copy link
Contributor

anandwana001 commented Jul 29, 2020 •
edited by rt4914
Loading

Describe the bug

  • Text Size of Exploration not changing as soon as we update the text size in options.
  • Text Size also affecting the Options Screen text OptionsActivity as well as HelpActivity or any possible screen we can go after starting Exploration.

To Reproduce
Steps to reproduce the behaviour:
Go to any exploration -> click on overflow menu -> options -> change the text size -> back to exploration -> text size not changed -> leave the exploration -> enter the exploration again -> text size changed -> click on overflow menu ->
text size of menu gets affected -> click on options or help -> you can see text size affected for all text on screen

Expected behaviour
Text size should only be updated for the only exploration player, not any other screen

Screenshots

Device
Pixel XL API 28
@anandwana001 anandwana001 added this to the Alpha milestone Jul 29, 2020
@anandwana001 anandwana001 mentioned this issue Jul 29, 2020
Closed
5 tasks
@anandwana001 anandwana001 self-assigned this Jul 29, 2020
@BenHenning
Copy link
Member

I think we shouldn't block alpha on this bug. While it's annoying, it's not totally app breaking & alpha is focusing on core functionality, not peripheral behaviors.

@BenHenning BenHenning modified the milestones: Alpha, Beta Jul 29, 2020
@anandwana001
Copy link
Contributor Author

anandwana001 commented Jul 29, 2020 •
edited
Loading

Ok

I think we shouldn't block alpha on this bug. While it's annoying, it's not totally app breaking & alpha is focusing on core functionality, not peripheral behaviors.

Ok, Let's take this on later

@anandwana001 anandwana001 removed their assignment Jul 30, 2020
@rt4914 rt4914 self-assigned this Sep 24, 2020
@rt4914
Copy link
Contributor

rt4914 commented Sep 24, 2020

@rt4914 Assigning this to myself for now so that I can divide this into multiple issues.

@chrk2205 chrk2205 mentioned this issue Nov 21, 2020
Closed
@FareesHussain
Copy link
Contributor

@rt4914 I'll create a PR for the second bug in the description as the first bug requires some time

@rt4914
Copy link
Contributor

rt4914 commented Jan 5, 2021

@rt4914 I'll create a PR for the second bug in the description as the first bug requires some time

@FareesHussain Sounds good.

@rt4914 rt4914 assigned FareesHussain and unassigned rt4914 Jan 5, 2021
@FareesHussain FareesHussain mentioned this issue Jan 5, 2021
Merged
8 tasks
@FareesHussain FareesHussain mentioned this issue Feb 2, 2021
Closed
8 tasks
@prayutsu
Copy link
Contributor

/cc @BenHenning

When reading text size is updated, the other UI components like DialogFragment are also affected -
Screenshot_2021-04-27-11-26-11-738_org oppia android

@BenHenning
Copy link
Member

Note that this was found while testing alpha MR2 but is determined to not be a blocker.

@rt4914
Copy link
Contributor

rt4914 commented Nov 18, 2021

@FareesHussain Unassigning you from this issue because of inactivity, please re-assign yourself if you are currently working on this.

@Broppia Broppia added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jul 29, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@MohitGupta121
Copy link
Member

MohitGupta121 commented Oct 11, 2022 •
edited
Loading

@BenHenning I'm try to reproduce this issue but for LessonFragment text size is changing as soon as we update, we need this as solution?

But for the RevisionFragment even Text Size is not changing from all ways. Text size changing is not implement for RevisionFragment or it's an issue?

oppiarec.mp4

@BenHenning
Copy link
Member

Thanks @MohitGupta121. I think this was fixed in #4411 so we can close this.

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2022
Repository owner moved this from Needs Triage to Done in [Team] Core Learner and Mastery flows & UI Frontend - Android Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
8 participants
@MohamedMedhat1998 @rt4914 @BenHenning @anandwana001 @prayutsu @FareesHussain @MohitGupta121 @Broppia