Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Reconciliation of cluster extension content not working on main branch #983

Closed
Tracked by #950
skattoju opened this issue Jun 27, 2024 · 3 comments · Fixed by #1074
Closed
Tracked by #950

[Bug] Reconciliation of cluster extension content not working on main branch #983

skattoju opened this issue Jun 27, 2024 · 3 comments · Fixed by #1074
Labels
kind/bug Categorizes issue or PR as related to a bug. v1.0 Issues related to the initial stable release of OLMv1

Comments

@skattoju
Copy link
Contributor

Since we setup watches for all objects installed by a cluster extension. It is expected that the controller will reconcile cluster extension content in case any of it is modified. However this does not work as expected.

Steps to reproduce:

  1. Switch to main branch
  2. make run
  3. Deploy sample catalog
  4. Deploy sample extension
  5. Delete deployment of extension controller

Expected Result:
The controller should react and recreate the deployment

Actual Result:
The controller does not react

@bentito
Copy link
Contributor

bentito commented Jun 27, 2024

Hi, thanks for the bug report. So to check things out, I immediately ran make test-e2e. All pass and we think they're fairly realistic end-to-end tests, so... Any chance you could reframe this bug report more along the lines of these tests (or at least with similar components and usages, Kind cluster, the catalog installer script, etc)? Seems like it would be more likely to result in a reproducer and be something folks can work on.

@skattoju
Copy link
Contributor Author

Hi Brett, there is not yet an e2e test for this scenario, I guess it will get implemented as part of work related to #737 The way the content is watched is changing so this will probably be fixed when #975 is done.

@joelanford
Copy link
Member

This test would be independent of the SA work. We should specifically track it to make sure the functionality works as expected.

@joelanford joelanford added v1.0 Issues related to the initial stable release of OLMv1 kind/bug Categorizes issue or PR as related to a bug. labels Jul 9, 2024
@joelanford joelanford added this to OLM v1 Jul 9, 2024
@ankitathomas ankitathomas moved this to Done in OLM v1 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. v1.0 Issues related to the initial stable release of OLMv1
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants