You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we set AuthNamespace to ext.Spec.InstallNamespace this will mean that we will have to create a pull secret for image registry in the ext.Spec.InstallNamespace. Is this what we want to achieve? Oh, and we will also have to have a pull secret support (has to be in line with #1015, I suspect).
The original idea was that a user would be able to specify an image pull secret on the ClusterExtension object. We don't have that field on our API, which explains why we don't plumb it through to the library.
Perhaps for now, in order to reduce the likelihood of the current unused setup being cargo-culted in the future, we should strip out the unused plumbing and internal API fields (that we control) that accept image pull secret configuration?
See:
operator-controller/cmd/manager/main.go
Line 180 in f301f55
This likely means a slight refactoring of the ImageRegistry implementation.
Related: it probably makes sense to stop using the composite unpacker and instead just use
ImageRegistry
directly.The text was updated successfully, but these errors were encountered: