-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolution fails when manually upgrading through legacy replaces chain beyond n+1 #1009
Comments
Definitely a blocker, IMO. Any idea why this is happening? My initial suspicion is that we somehow have an incorrect understanding of the currently installed version? |
That is my suspicion as well. It seems like
|
It's happening because the helm release for the upgraded bundle still has the first version label. When we install we set the version label: operator-controller/internal/controllers/clusterextension_controller.go Lines 355 to 372 in 7cc9872
but we're not doing the same for the upgrade case. |
When attempting to manually step through upgrading versions of a package using the
ClusterExtension
using thereplaces
chain in the FBC channel, moving beyond the first replaced version results in the following status condition:In this case, I had followed the replaces chain from
v0.1.0
-->v0.2.0
successfully. When attempting to go fromv0.2.0
-->v0.3.0
the upgrade failed and contained the above resolution failure.To verify this is a valid upgrade path, you can see the channel and upgrade edges with:
Output
ClusterCatalog
that references the operatorhub.io catalog image:ClusterExtension
that installs theargocd-operator
atv0.1.0
:ClusterExtension
is successfully installed, manually update the version tov0.2.0
(note you will have to disable the recently added CRD Upgrade Safety check for this to work due to unknown changes to argo's CRDs):v0.3.0
:You should now be able to see the same resolution failure.
Full ClusterExtension output YAML
Just to note, this was originally found by OpenShift QE. I verified the bug was reproducible and used a different package for installation.
The text was updated successfully, but these errors were encountered: