Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinating the creation/endorsement of a OpenTracing->Zipkin tracer #191

Closed
cwe1ss opened this issue Mar 12, 2018 · 6 comments
Closed

Comments

@cwe1ss
Copy link

cwe1ss commented Mar 12, 2018

We've recently released a new version of the OpenTracing C# API that now has parity with Java and therefore can be considered "ready to be used".

I'd like to use this issue to bring everyone together who has been working either on zipkin4net, OpenTracing or a bridge to see if we can join forces somehow to have at least one "official" OpenTracing->Zipkin bridge. I'm using this repository as this project has been selected as the official C# API for Zipkin.

OpenTracing->Zipkin bridges and their contributors:

People who have recently been active in opentracing-csharp and have not yet been mentioned: @Aaronontheweb, @bmermet, @carlosalberto, @dawallin, @Falco20019, @MikeGoldsmith, @ndrwrbgs, @TerribleDev

Contributors to zipkin4net (> 1 commit): @fedj, @klettier, @flodav, @crntn, @bhugot, @anthonywanted, @adriancole, @kerdrek

Some of my questions:

  • The existing bridges on nuget.org (Butterfly, Jasiri, LetsTrace) do not use zipkin4net. What are the issues?
  • What is the state of the existing bridges? (in development? / used in production?)
  • Are any of the bridge authors interested in joining forces/consolidating work?
  • Who else is interested in helping?
  • What needs to be done to make any of the projects "official" (or at least to have a group of people supporting it)?

Any feedback is appreciated! Also, feel free to /cc other people who would be interested.

@Falco20019
Copy link

Falco20019 commented Mar 12, 2018

I recently worked on LetsTrace. It‘s not using zipkin4net since it tries to be an lightweight plugin into LetsTrace which also supports Jaeger/Thrift for its tracer. Right now I‘m working with @grounded042 to get LetsTrace on feature parity with the Java Jaeger client and to make it official (see jaegertracing/jaeger#578)

Right now I prepare to use LetsTrace in production for tracing of gRPC. Have also an grpc interceptor for C# nearly finished which uses your OpenTracing as base (see https://github.com/Falco20019/grpc-opentracing/tree/csharp-experimental).

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Mar 13, 2018 via email

@grounded042
Copy link

Our plan is to have a plugin for LetsTrace that will work with Zipkin. We have the beginnings of it, but need to do more before it's up and running.

@cwe1ss
Copy link
Author

cwe1ss commented Sep 14, 2018

Some updates:

@codefromthecrypt
Copy link
Member

fyi any opentracing bridge to this will be best placed in a contrib library. if history is any lesson, things move at different speeds, in different directions and by folks with different stakes. same thing for census.

another note is I don't think it is in the scope of this repo to promote opentracing or other libraries. currently we use the openzipkin.github.io site to do that.

bottom line is I think the other available tracers can be put on the web site. if a bridge ends up being made for this it can go in contrib either way there is no activity in this repo.

thanks for the follow up all the same

@cwe1ss
Copy link
Author

cwe1ss commented Sep 17, 2018

agreed. thank you @adriancole !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants